adding some TODOs

This commit is contained in:
frankknoll
2023-01-27 08:17:03 +01:00
parent 6e91398383
commit cb2dffcb57
3 changed files with 24 additions and 1 deletions

View File

@@ -22,6 +22,7 @@ class BatchCodeTableFactory:
def _postProcess(self, batchCodeTable): def _postProcess(self, batchCodeTable):
batchCodeTable = self.companyColumnAdder.addCompanyColumn(batchCodeTable) batchCodeTable = self.companyColumnAdder.addCompanyColumn(batchCodeTable)
# FK-TODO: remove Symptoms column everywhere
batchCodeTable['Symptoms'] = '{"Circulatory collapse":1,"Hyperhidrosis":1}' batchCodeTable['Symptoms'] = '{"Circulatory collapse":1,"Hyperhidrosis":1}'
batchCodeTable = batchCodeTable[ batchCodeTable = batchCodeTable[
[ [

View File

@@ -26,4 +26,5 @@ class DictByBatchcodeTable2JsonConverter:
@staticmethod @staticmethod
def _getNaNBatchcodes(batchcodes): def _getNaNBatchcodes(batchcodes):
# FK-TODO: handle 'nan' everywhere correctly
return [batchcode for batchcode in batchcodes if batchcode != 'nan'] return [batchcode for batchcode in batchcodes if batchcode != 'nan']

View File

@@ -168,6 +168,16 @@
"dictByBatchcodeTable" "dictByBatchcodeTable"
] ]
}, },
{
"cell_type": "code",
"execution_count": null,
"id": "5c77a3d4",
"metadata": {},
"outputs": [],
"source": [
"dictByBatchcodeTable"
]
},
{ {
"cell_type": "code", "cell_type": "code",
"execution_count": null, "execution_count": null,
@@ -189,10 +199,21 @@
"source": [ "source": [
"from DictByBatchcodeTable2JsonConverter import DictByBatchcodeTable2JsonConverter\n", "from DictByBatchcodeTable2JsonConverter import DictByBatchcodeTable2JsonConverter\n",
"import json\n", "import json\n",
"# FK-TODO: convertDictByBatchcodeTable2Json() für alle Batchcodes aufrufen und jedes Ergebnis in einer Datei batchcode.json speichern.\n",
"jsonActual = DictByBatchcodeTable2JsonConverter.convertDictByBatchcodeTable2Json(filteredTable, 'FE6208')\n", "jsonActual = DictByBatchcodeTable2JsonConverter.convertDictByBatchcodeTable2Json(filteredTable, 'FE6208')\n",
"print(json.dumps(json.loads(jsonActual), indent=2))" "print(json.dumps(json.loads(jsonActual), indent=2))"
] ]
}, },
{
"cell_type": "code",
"execution_count": null,
"id": "97e2a4b6",
"metadata": {},
"outputs": [],
"source": [
"print(json.dumps(json.loads(jsonActual), indent=2))"
]
},
{ {
"cell_type": "code", "cell_type": "code",
"execution_count": null, "execution_count": null,
@@ -485,7 +506,7 @@
"name": "python", "name": "python",
"nbconvert_exporter": "python", "nbconvert_exporter": "python",
"pygments_lexer": "ipython3", "pygments_lexer": "ipython3",
"version": "3.10.8" "version": "3.10.8 (main, Nov 24 2022, 14:13:03) [GCC 11.2.0]"
}, },
"vscode": { "vscode": {
"interpreter": { "interpreter": {