From cb2dffcb5756452a85b0bfce7543bfea3e99d0a2 Mon Sep 17 00:00:00 2001
From: frankknoll <Knoll_Frank@web.de>
Date: Fri, 27 Jan 2023 08:17:03 +0100
Subject: [PATCH] adding some TODOs

---
 src/BatchCodeTableFactory.py              |  1 +
 src/DictByBatchcodeTable2JsonConverter.py |  1 +
 src/HowBadIsMyBatch.ipynb                 | 23 ++++++++++++++++++++++-
 3 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/src/BatchCodeTableFactory.py b/src/BatchCodeTableFactory.py
index c9bb3627bc9..d1aaf9e29f7 100644
--- a/src/BatchCodeTableFactory.py
+++ b/src/BatchCodeTableFactory.py
@@ -22,6 +22,7 @@ class BatchCodeTableFactory:
 
     def _postProcess(self, batchCodeTable):
         batchCodeTable = self.companyColumnAdder.addCompanyColumn(batchCodeTable)
+        # FK-TODO: remove Symptoms column everywhere
         batchCodeTable['Symptoms'] = '{"Circulatory collapse":1,"Hyperhidrosis":1}'
         batchCodeTable = batchCodeTable[
             [
diff --git a/src/DictByBatchcodeTable2JsonConverter.py b/src/DictByBatchcodeTable2JsonConverter.py
index e7340e24537..11a9625efe5 100644
--- a/src/DictByBatchcodeTable2JsonConverter.py
+++ b/src/DictByBatchcodeTable2JsonConverter.py
@@ -26,4 +26,5 @@ class DictByBatchcodeTable2JsonConverter:
     
     @staticmethod
     def _getNaNBatchcodes(batchcodes):
+        # FK-TODO: handle 'nan' everywhere correctly
         return [batchcode for batchcode in batchcodes if batchcode != 'nan']
diff --git a/src/HowBadIsMyBatch.ipynb b/src/HowBadIsMyBatch.ipynb
index 82d1db84686..d16a6732070 100644
--- a/src/HowBadIsMyBatch.ipynb
+++ b/src/HowBadIsMyBatch.ipynb
@@ -168,6 +168,16 @@
     "dictByBatchcodeTable"
    ]
   },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "id": "5c77a3d4",
+   "metadata": {},
+   "outputs": [],
+   "source": [
+    "dictByBatchcodeTable"
+   ]
+  },
   {
    "cell_type": "code",
    "execution_count": null,
@@ -189,10 +199,21 @@
    "source": [
     "from DictByBatchcodeTable2JsonConverter import DictByBatchcodeTable2JsonConverter\n",
     "import json\n",
+    "# FK-TODO: convertDictByBatchcodeTable2Json() für alle Batchcodes aufrufen und jedes Ergebnis in einer Datei batchcode.json speichern.\n",
     "jsonActual = DictByBatchcodeTable2JsonConverter.convertDictByBatchcodeTable2Json(filteredTable, 'FE6208')\n",
     "print(json.dumps(json.loads(jsonActual), indent=2))"
    ]
   },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "id": "97e2a4b6",
+   "metadata": {},
+   "outputs": [],
+   "source": [
+    "print(json.dumps(json.loads(jsonActual), indent=2))"
+   ]
+  },
   {
    "cell_type": "code",
    "execution_count": null,
@@ -485,7 +506,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.10.8"
+   "version": "3.10.8 (main, Nov 24 2022, 14:13:03) [GCC 11.2.0]"
   },
   "vscode": {
    "interpreter": {