refactoring

This commit is contained in:
frankknoll
2022-02-06 11:27:15 +01:00
parent 6c9755ad62
commit 4ba08fcf1d

View File

@@ -131,9 +131,6 @@
" def filterBy(self, dataFrame, manufacturer = None, dose = None):\n",
" return dataFrame[self._isManufacturer(dataFrame, manufacturer) & self._isDose(dataFrame, dose)]\n",
"\n",
" def filterForSevereEffects(self, dataFrame, dose):\n",
" return self.filterBy(self.filterByCovid19(dataFrame), dose = dose)\n",
"\n",
" def _isCovid19(self, dataFrame):\n",
" return dataFrame[\"VAX_TYPE\"] == \"COVID19\"\n",
"\n",
@@ -247,8 +244,9 @@
" # create table from https://www.howbadismybatch.com/combined.html\n",
" @staticmethod\n",
" def createSevereEffectsBatchCodeTable(dataFrame : pd.DataFrame, dose):\n",
" severeEffectsDataFrame = DataFrameFilter().filterForSevereEffects(dataFrame, dose)\n",
" return BatchCodeTableHelper(severeEffectsDataFrame).createSevereEffectsBatchCodeTable()\n"
" dataFrame = DataFrameFilter().filterByCovid19(dataFrame)\n",
" dataFrame = DataFrameFilter().filterBy(dataFrame, dose = dose)\n",
" return BatchCodeTableHelper(dataFrame).createSevereEffectsBatchCodeTable()\n"
]
},
{
@@ -375,7 +373,7 @@
" dtypes = {'VAX_DOSE_SERIES': \"string\"})\n",
" assert_frame_equal(dataFrame, dataFrameExpected, check_dtype = False)\n",
"\n",
" def test_filterForSevereEffects(self):\n",
" def test_filterByDose(self):\n",
" # Given\n",
" dataFrame = VaersDescr2DataFrameConverter.createDataFrameFromDescrs(\n",
" [\n",
@@ -398,9 +396,10 @@
" }\n",
" ])\n",
" dataFrameFilter = DataFrameFilter()\n",
" dataFrame = dataFrameFilter.filterByCovid19(dataFrame)\n",
"\n",
" # When\n",
" dataFrame = dataFrameFilter.filterForSevereEffects(dataFrame, dose = '1')\n",
" dataFrame = dataFrameFilter.filterBy(dataFrame, dose = '1')\n",
" \n",
" # Then\n",
" dataFrameExpected = self.createDataFrame(\n",