From fb53822fdcfa370bbf5de3758d12b7332ae7cf83 Mon Sep 17 00:00:00 2001
From: frankknoll <Knoll_Frank@web.de>
Date: Sun, 15 Oct 2023 15:23:10 +0200
Subject: [PATCH] refactoring

---
 docs/SymptomsCausedByVaccines/index.html      |  1 +
 .../js/PrrByKeyTableView.js                   | 44 ++++++++++++++++
 .../js/PrrBySymptomTable.js                   | 14 +++++
 .../js/PrrBySymptomTableView.js               | 51 +++----------------
 .../js/PrrByVaccineTableView.js               | 39 +++-----------
 test/SymptomsCausedByVaccines/index.test.html |  1 +
 6 files changed, 74 insertions(+), 76 deletions(-)
 create mode 100644 docs/SymptomsCausedByVaccines/js/PrrByKeyTableView.js

diff --git a/docs/SymptomsCausedByVaccines/index.html b/docs/SymptomsCausedByVaccines/index.html
index 556ca798dd6..d13d55058c5 100644
--- a/docs/SymptomsCausedByVaccines/index.html
+++ b/docs/SymptomsCausedByVaccines/index.html
@@ -33,6 +33,7 @@
   <script src="./js/PrrByVaccineProvider.js"></script>
   <script src="./js/PrrByVaccineTable.js"></script>
   <script src="./js/PrrBySymptomTable.js"></script>
+  <script src="./js/PrrByKeyTableView.js"></script>
   <script src="./js/PrrByVaccineTableView.js"></script>
   <script src="./js/PrrBySymptomTableView.js"></script>
   <script>
diff --git a/docs/SymptomsCausedByVaccines/js/PrrByKeyTableView.js b/docs/SymptomsCausedByVaccines/js/PrrByKeyTableView.js
new file mode 100644
index 00000000000..9694a94125b
--- /dev/null
+++ b/docs/SymptomsCausedByVaccines/js/PrrByKeyTableView.js
@@ -0,0 +1,44 @@
+class PrrByKeyTableView {
+
+    #prrByKeyTable;
+    #downloadPrrByKeyTableButton;
+    #value;
+    #valueName;
+    #prrByKeyProvider;
+
+    constructor(prrByKeyTable, downloadPrrByKeyTableButton, valueName, prrByKeyProvider) {
+        this.#prrByKeyTable = prrByKeyTable;
+        this.#prrByKeyTable.initialize();
+        this.#initializeButton(downloadPrrByKeyTableButton);
+        this.#valueName = valueName;
+        this.#prrByKeyProvider = prrByKeyProvider;
+    }
+
+    displayPrrByKeyTable4Value(value) {
+        UIUtils.disableButton(this.#downloadPrrByKeyTableButton);
+        this.#prrByKeyProvider(value)
+            .then(prrByKey => {
+                this.#value = value;
+                this.#prrByKeyTable.display(prrByKey);
+                UIUtils.enableButton(this.#downloadPrrByKeyTableButton);
+            });
+    }
+
+    #initializeButton(downloadPrrByKeyTableButton) {
+        this.#downloadPrrByKeyTableButton = downloadPrrByKeyTableButton;
+        UIUtils.disableButton(downloadPrrByKeyTableButton);
+        downloadPrrByKeyTableButton.addEventListener(
+            'click',
+            () => this.#downloadPrrByKey())
+    }
+
+    #downloadPrrByKey() {
+        UIUtils.downloadUrlAsFilename(
+            window.URL.createObjectURL(
+                new Blob(
+                    [this.#prrByKeyTable.getDisplayedTableAsCsv(`# ${this.#valueName}: ${this.#value}`)],
+                    { type: 'text/csv' })),
+            this.#value
+        );
+    }
+}
diff --git a/docs/SymptomsCausedByVaccines/js/PrrBySymptomTable.js b/docs/SymptomsCausedByVaccines/js/PrrBySymptomTable.js
index 4543271adb0..28268aef55a 100644
--- a/docs/SymptomsCausedByVaccines/js/PrrBySymptomTable.js
+++ b/docs/SymptomsCausedByVaccines/js/PrrBySymptomTable.js
@@ -3,6 +3,7 @@ class PrrBySymptomTable {
     #tableElement;
     #table;
     #sumPrrs;
+    #prrBySymptom;
 
     constructor(tableElement) {
         this.#tableElement = tableElement;
@@ -13,10 +14,23 @@ class PrrBySymptomTable {
     }
 
     display(prrBySymptom) {
+        this.#prrBySymptom = prrBySymptom;
         const symptom_prr_pairs = Object.entries(prrBySymptom);
         this.#setTableRows(symptom_prr_pairs);
     }
 
+    getDisplayedTableAsCsv(heading) {
+        return PrrByKey2CsvConverter.convertPrrByKey2Csv(
+            {
+                heading: heading,
+                columns: {
+                    keyColumn: 'Symptom',
+                    prrColumn: 'Proportional Reporting Ratio > 1'
+                },
+                prrByKey: this.#prrBySymptom
+            });
+    }
+
     #createEmptyTable() {
         return this.#tableElement.DataTable(
             {
diff --git a/docs/SymptomsCausedByVaccines/js/PrrBySymptomTableView.js b/docs/SymptomsCausedByVaccines/js/PrrBySymptomTableView.js
index 995e690a877..19cc539c2ac 100644
--- a/docs/SymptomsCausedByVaccines/js/PrrBySymptomTableView.js
+++ b/docs/SymptomsCausedByVaccines/js/PrrBySymptomTableView.js
@@ -1,53 +1,16 @@
 class PrrBySymptomTableView {
 
-    #prrBySymptomTable;
-    #downloadPrrBySymptomTableButton;
-    #prrBySymptom;
-    #vaccine;
+    #delegate;
 
     constructor(prrBySymptomTableElement, downloadPrrBySymptomTableButton) {
-        this.#prrBySymptomTable = new PrrBySymptomTable(prrBySymptomTableElement);
-        this.#prrBySymptomTable.initialize();
-        this.#initializeButton(downloadPrrBySymptomTableButton);
+        this.#delegate = new PrrByKeyTableView(
+            new PrrBySymptomTable(prrBySymptomTableElement),
+            downloadPrrBySymptomTableButton,
+            'Vaccine',
+            PrrByVaccineProvider.getPrrBySymptom);
     }
 
     displayPrrBySymptomTable4Vaccine(vaccine) {
-        UIUtils.disableButton(this.#downloadPrrBySymptomTableButton);
-        PrrByVaccineProvider
-            .getPrrBySymptom(vaccine)
-            .then(prrBySymptom => {
-                this.#prrBySymptom = prrBySymptom;
-                this.#vaccine = vaccine;
-                this.#prrBySymptomTable.display(prrBySymptom);
-                UIUtils.enableButton(this.#downloadPrrBySymptomTableButton);
-            });
-    }
-
-    #initializeButton(downloadPrrBySymptomTableButton) {
-        this.#downloadPrrBySymptomTableButton = downloadPrrBySymptomTableButton;
-        UIUtils.disableButton(downloadPrrBySymptomTableButton);
-        downloadPrrBySymptomTableButton.addEventListener(
-            'click',
-            () => this.#downloadPrrBySymptom())
-    }
-
-    #downloadPrrBySymptom() {
-        UIUtils.downloadUrlAsFilename(
-            window.URL.createObjectURL(
-                new Blob(
-                    [
-                        PrrByKey2CsvConverter.convertPrrByKey2Csv(
-                            {
-                                heading: '# Vaccine: ' + this.#vaccine,
-                                columns: {
-                                    keyColumn: 'Symptom',
-                                    prrColumn: 'Proportional Reporting Ratio > 1'
-                                },
-                                prrByKey: this.#prrBySymptom
-                            })
-                    ],
-                    { type: 'text/csv' })),
-            this.#vaccine
-        );
+        this.#delegate.displayPrrByKeyTable4Value(vaccine);
     }
 }
diff --git a/docs/SymptomsCausedByVaccines/js/PrrByVaccineTableView.js b/docs/SymptomsCausedByVaccines/js/PrrByVaccineTableView.js
index 76423f16169..d63a69f46b3 100644
--- a/docs/SymptomsCausedByVaccines/js/PrrByVaccineTableView.js
+++ b/docs/SymptomsCausedByVaccines/js/PrrByVaccineTableView.js
@@ -1,41 +1,16 @@
 class PrrByVaccineTableView {
 
-    #prrByVaccineTable;
-    #downloadPrrByVaccineTableButton;
-    #symptom;
+    #delegate;
 
     constructor(prrByVaccineTableElement, downloadPrrByVaccineTableButton) {
-        this.#prrByVaccineTable = new PrrByVaccineTable(prrByVaccineTableElement);
-        this.#prrByVaccineTable.initialize();
-        this.#initializeButton(downloadPrrByVaccineTableButton);
+        this.#delegate = new PrrByKeyTableView(
+            new PrrByVaccineTable(prrByVaccineTableElement),
+            downloadPrrByVaccineTableButton,
+            'Symptom',
+            PrrByVaccineProvider.getPrrByVaccine);
     }
 
     displayPrrByVaccineTable4Symptom(symptom) {
-        UIUtils.disableButton(this.#downloadPrrByVaccineTableButton);
-        PrrByVaccineProvider
-            .getPrrByVaccine(symptom)
-            .then(prrByVaccine => {
-                this.#symptom = symptom;
-                this.#prrByVaccineTable.display(prrByVaccine);
-                UIUtils.enableButton(this.#downloadPrrByVaccineTableButton);
-            });
-    }
-
-    #initializeButton(downloadPrrByVaccineTableButton) {
-        this.#downloadPrrByVaccineTableButton = downloadPrrByVaccineTableButton;
-        UIUtils.disableButton(downloadPrrByVaccineTableButton);
-        downloadPrrByVaccineTableButton.addEventListener(
-            'click',
-            () => this.#downloadPrrByVaccine())
-    }
-
-    #downloadPrrByVaccine() {
-        UIUtils.downloadUrlAsFilename(
-            window.URL.createObjectURL(
-                new Blob(
-                    [this.#prrByVaccineTable.getDisplayedTableAsCsv('# Symptom: ' + this.#symptom)],
-                    { type: 'text/csv' })),
-            this.#symptom
-        );
+        this.#delegate.displayPrrByKeyTable4Value(symptom);
     }
 }
diff --git a/test/SymptomsCausedByVaccines/index.test.html b/test/SymptomsCausedByVaccines/index.test.html
index c347f45de30..a775a4aa996 100644
--- a/test/SymptomsCausedByVaccines/index.test.html
+++ b/test/SymptomsCausedByVaccines/index.test.html
@@ -16,6 +16,7 @@
   <script src="../../docs/SymptomsCausedByVaccines/js/PrrByVaccineProvider.js"></script>
   <script src="../../docs/SymptomsCausedByVaccines/js/PrrByVaccineTable.js"></script>
   <script src="../../docs/SymptomsCausedByVaccines/js/PrrBySymptomTable.js"></script>
+  <script src="../../docs/SymptomsCausedByVaccines/js/PrrByKeyTableView.js"></script>
   <script src="../../docs/SymptomsCausedByVaccines/js/PrrByVaccineTableView.js"></script>
   <script src="../../docs/SymptomsCausedByVaccines/js/PrrBySymptomTableView.js"></script>
   <link rel="stylesheet" href="https://code.jquery.com/qunit/qunit-2.17.2.css">