From ebb76878f651e6ee361b4709fc0cfc6c0481a8f3 Mon Sep 17 00:00:00 2001 From: frankknoll Date: Sat, 15 Apr 2023 23:41:29 +0200 Subject: [PATCH] refactoring --- docs/BatchCodeDetailsView.js | 6 +++--- docs/BatchcodeCombinationSelection.js | 12 ++++++------ docs/batchCodeTable.html | 2 +- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/docs/BatchCodeDetailsView.js b/docs/BatchCodeDetailsView.js index 58d086edc4d..6cc53821dd2 100644 --- a/docs/BatchCodeDetailsView.js +++ b/docs/BatchCodeDetailsView.js @@ -2,7 +2,7 @@ class BatchCodeDetailsView { #uiContainer; #headingElement; - #batchcodesSelectElement; + #batchCodesSelectElement; #adverseReactionReportsChartView; #histogramChartView; #chartWithSlider; @@ -10,7 +10,7 @@ class BatchCodeDetailsView { constructor(uiContainer) { this.#uiContainer = uiContainer this.#headingElement = this.#uiContainer.querySelector(".heading"); - this.#batchcodesSelectElement = new ElementWithSingleChangeEventListener(this.#uiContainer.querySelector("#batchcodesSelect")); + this.#batchCodesSelectElement = new ElementWithSingleChangeEventListener(this.#uiContainer.querySelector("#batchCodesSelect")); this.#adverseReactionReportsChartView = new AdverseReactionReportsChartView(this.#uiContainer.querySelector('#adverseReactionReportsChartView')); this.#chartWithSlider = this.#uiContainer.querySelector('.chartWithSlider'); this.#histogramChartView = new HistogramChartView(this.#chartWithSlider.querySelector("canvas")); @@ -58,7 +58,7 @@ class BatchCodeDetailsView { #displaySelectBatchcodeCombination(histograms) { BatchcodeCombinationSelection.configureSelectBatchcodeCombinationElement( { - batchcodesSelectElement: this.#batchcodesSelectElement, + batchCodesSelectElement: this.#batchCodesSelectElement, histograms: histograms, onSelect: histoDescr => this.#displayHistogram(histoDescr) }); diff --git a/docs/BatchcodeCombinationSelection.js b/docs/BatchcodeCombinationSelection.js index 8f914b18c16..3cf854125f4 100644 --- a/docs/BatchcodeCombinationSelection.js +++ b/docs/BatchcodeCombinationSelection.js @@ -1,8 +1,8 @@ class BatchcodeCombinationSelection { - static configureSelectBatchcodeCombinationElement({ batchcodesSelectElement, histograms, onSelect }) { - this.#setBatchcodeCombinationOptions(batchcodesSelectElement.element, histograms); - batchcodesSelectElement.setSingleChangeEventListener( + static configureSelectBatchcodeCombinationElement({ batchCodesSelectElement, histograms, onSelect }) { + this.#setBatchcodeCombinationOptions(batchCodesSelectElement.element, histograms); + batchCodesSelectElement.setSingleChangeEventListener( event => { const histoDescr = histograms[event.target.value]; onSelect(histoDescr); @@ -10,9 +10,9 @@ class BatchcodeCombinationSelection { onSelect(histograms[0]); } - static #setBatchcodeCombinationOptions(batchcodesSelectElement, histograms) { - UIUtils.clear(batchcodesSelectElement); - this.#getBatchcodeCombinationOptions(histograms).forEach(option => batchcodesSelectElement.add(option)); + static #setBatchcodeCombinationOptions(batchCodesSelectElement, histograms) { + UIUtils.clear(batchCodesSelectElement); + this.#getBatchcodeCombinationOptions(histograms).forEach(option => batchCodesSelectElement.add(option)); } static #getBatchcodeCombinationOptions(histograms) { diff --git a/docs/batchCodeTable.html b/docs/batchCodeTable.html index b90c1ab9699..e00b73689aa 100644 --- a/docs/batchCodeTable.html +++ b/docs/batchCodeTable.html @@ -49768,7 +49768,7 @@