From 963f60dc5a17ae0b6b9162715c995fad379d6feb Mon Sep 17 00:00:00 2001
From: frankknoll <Knoll_Frank@web.de>
Date: Fri, 14 Apr 2023 11:46:40 +0200
Subject: [PATCH] refactoring

---
 docs/AdverseReactionReportsChartView.js |  3 ++-
 docs/BatchCodeSelectInitializer.js      | 10 +++++-----
 docs/HistogramView.js                   |  1 +
 docs/batchCodeTable.html                |  6 +++---
 src/help.txt                            |  1 +
 5 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/docs/AdverseReactionReportsChartView.js b/docs/AdverseReactionReportsChartView.js
index 740731a1ca8..ab96c463374 100644
--- a/docs/AdverseReactionReportsChartView.js
+++ b/docs/AdverseReactionReportsChartView.js
@@ -14,7 +14,8 @@ class AdverseReactionReportsChartView {
         this.#chart = new Chart(
             this.#canvas,
             {
-                type: 'doughnut',
+                // FK-TODO: use a Polar Area Chart ('polarArea') or bar chart
+                type: 'bar',
                 data: this.#getData(ADRDescr),
                 options: this.#getOptions()
             });
diff --git a/docs/BatchCodeSelectInitializer.js b/docs/BatchCodeSelectInitializer.js
index 9a4696e46fc..834ecb017b5 100644
--- a/docs/BatchCodeSelectInitializer.js
+++ b/docs/BatchCodeSelectInitializer.js
@@ -1,14 +1,14 @@
 class BatchCodeSelectInitializer {
 
-    static initialize({batchCodeSelect, batchCodeDetails}) {
-        batchCodeSelect.select2({ minimumInputLength: 4 });
-        batchCodeSelect.on(
+    static initialize({batchCodeSelectElement, batchCodeDetailsElement}) {
+        batchCodeSelectElement.select2({ minimumInputLength: 4 });
+        batchCodeSelectElement.on(
             'select2:select',
             function (event) {
                 const batchcode = event.params.data.id;
-                new HistogramView(batchCodeDetails).displayHistogramView(batchcode);
+                new HistogramView(batchCodeDetailsElement).displayHistogramView(batchcode);
                 GoogleAnalytics.click_batchcode(batchcode);
             });
-        batchCodeSelect.select2('open');
+        batchCodeSelectElement.select2('open');
     }
 }
diff --git a/docs/HistogramView.js b/docs/HistogramView.js
index fc4813ef92e..29f45bfd610 100644
--- a/docs/HistogramView.js
+++ b/docs/HistogramView.js
@@ -1,3 +1,4 @@
+// FK-TODO: rename to BatchCodeDetailsView
 class HistogramView {
 
     #uiContainer;
diff --git a/docs/batchCodeTable.html b/docs/batchCodeTable.html
index 0be3cf7e65b..2700efe2afa 100644
--- a/docs/batchCodeTable.html
+++ b/docs/batchCodeTable.html
@@ -41,8 +41,8 @@
     $(document).ready(function () {
       BatchCodeSelectInitializer.initialize(
         {
-          batchCodeSelect: $('#batchCodeSelect'),
-          batchCodeDetails: document.querySelector("#batchCodeDetails")
+          batchCodeSelectElement: $('#batchCodeSelect'),
+          batchCodeDetailsElement: document.querySelector("#batchCodeDetails")
         }
       );
     });
@@ -49762,7 +49762,7 @@
       <option value="Ø94F21A">Ø94F21A</option>
     </select>
   </p>
-  <div id="batchCodeDetails"></div>
+  <div id="batchCodeDetails" style="width: 50%"></div>
   <p><b>Data Source:</b>
     <a href="https://vaers.hhs.gov/data/datasets.html" target="_blank">Vaccine Adverse Event Reporting System
       (VAERS)</a>
diff --git a/src/help.txt b/src/help.txt
index 72fc8945b8e..d5d00ac4a9b 100644
--- a/src/help.txt
+++ b/src/help.txt
@@ -4,6 +4,7 @@ FK-FIXME:
 
 FK-TODO:
 - add google captcha to batchCodeTable.html
+- remove batch code combinations, use just a single batch code for symptom chart
 
 anacron job:
 sudo cp src/intensivstationen_howbadismybatch.sh /etc/cron.daily/intensivstationen_howbadismybatch