From 61f233377bcad1c1cba3ce4f683a398ddfbcbd22 Mon Sep 17 00:00:00 2001
From: frankknoll <Knoll_Frank@web.de>
Date: Fri, 11 Feb 2022 22:03:04 +0100
Subject: [PATCH] refactoring

---
 batchCodeTable.html | 109 +++++++++++++-------------------------------
 forkMeOnGitHub.css  |  63 +++++++++++++++++++++++++
 index.html          |  66 +--------------------------
 3 files changed, 96 insertions(+), 142 deletions(-)
 create mode 100644 forkMeOnGitHub.css
diff --git a/batchCodeTable.html b/batchCodeTable.html
index 29d5c2c68b5..b0dc34f471d 100644
--- a/batchCodeTable.html
+++ b/batchCodeTable.html
@@ -7,28 +7,36 @@
   <title>batch codes</title>
   <!-- FK-TODO: keine externen Links -->
   <link rel="stylesheet" type="text/css" href="https://cdn.datatables.net/1.11.4/css/jquery.dataTables.css">
+  <link rel="stylesheet" type="text/css" href="forkMeOnGitHub.css">
   <!-- FK-TODO: keine externen Links -->
   <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script>
   <!-- FK-TODO: keine externen Links -->
   <script type="text/javascript" charset="utf8"
     src="https://cdn.datatables.net/1.11.4/js/jquery.dataTables.min.js"></script>
   <script>
-    function capitalizeFirstLetter(str) {
-      return str.charAt(0).toUpperCase() + str.slice(1)
+    function getSearchParams() {
+      const searchParams = new URLSearchParams(window.location.search);
+      return {
+        company: searchParams.get('company'),
+        companyName: searchParams.get('companyName'),
+        title: searchParams.get('title')
+      };
     }
 
-    $(document).ready(function () {
-      const searchParams = new URLSearchParams(window.location.search);
-      const company = searchParams.get('company');
-      const companyName = searchParams.get('companyName');
-      const title = searchParams.get('title');
-      document.title = title;
-      document.querySelectorAll(".title").forEach(element => element.textContent = title);
-      document.querySelectorAll(".companyName").forEach(element => element.textContent = companyName);
-      $("#table").load("data/" + company + ".html", function () {
+    function replaceCssClassesWithStrs({ title, companyName }) {
+      replaceCssClassWithStr(".title", title);
+      replaceCssClassWithStr(".companyName", companyName);
+    }
+
+    function replaceCssClassWithStr(cssClass, str) {
+      document.querySelectorAll(cssClass).forEach(element => element.textContent = str);
+    }
+
+    function loadBatchCodeTable(file, searchPlaceholder) {
+      $("#batchCodeTableWrapper").load(file, function () {
         $('#batchCodeTable').DataTable({
           language: {
-            searchPlaceholder: "Enter " + companyName + " Batch Code"
+            searchPlaceholder: searchPlaceholder
           },
           search: {
             return: false
@@ -36,6 +44,13 @@
           "order": [[1, "desc"]]
         });
       });
+    }
+
+    $(document).ready(function () {
+      const { company, companyName, title } = getSearchParams();
+      document.title = title;
+      replaceCssClassesWithStrs({ title, companyName });
+      loadBatchCodeTable("data/" + company + ".html", "Enter " + companyName + " Batch Code");
     });
   </script>
   <style>
@@ -50,74 +65,12 @@
 </head>
 
 <body>
-  <!-- adapted from https://codepo8.github.io/css-fork-on-github-ribbon/ -->
-  <style>
-    #forkongithub a {
-      background: #000;
-      color: #fff;
-      text-decoration: none;
-      font-family: arial, sans-serif;
-      text-align: center;
-      font-weight: bold;
-      padding: 5px 40px;
-      font-size: 1rem;
-      line-height: 2rem;
-      position: relative;
-      transition: 0.5s;
-    }
-
-    #forkongithub a:hover {
-      background: #c11;
-      color: #fff;
-    }
-
-    #forkongithub a::before,
-    #forkongithub a::after {
-      content: "";
-      width: 100%;
-      display: block;
-      position: absolute;
-      top: 1px;
-      left: 0;
-      height: 1px;
-      background: #fff;
-    }
-
-    #forkongithub a::after {
-      bottom: 1px;
-      top: auto;
-    }
-
-    @media screen and (min-width:800px) {
-      #forkongithub {
-        position: absolute;
-        display: block;
-        top: 0;
-        right: 0;
-        width: 200px;
-        overflow: hidden;
-        height: 200px;
-        z-index: 9999;
-      }
-
-      #forkongithub a {
-        width: 200px;
-        position: absolute;
-        top: 60px;
-        right: -60px;
-        transform: rotate(45deg);
-        -webkit-transform: rotate(45deg);
-        -ms-transform: rotate(45deg);
-        -moz-transform: rotate(45deg);
-        -o-transform: rotate(45deg);
-        box-shadow: 4px 4px 10px rgba(0, 0, 0, 0.8);
-      }
-    }
-  </style><span id="forkongithub"><a href="https://github.com/KnollFrank/HowBadIsMyBatch">Fork me on GitHub</a></span>
+  <span id="forkongithub"><a href="https://github.com/KnollFrank/HowBadIsMyBatch">Fork me on GitHub</a></span>
   <h1 class="title"></h1>
   <p>
-    <b>Check out your <span class="companyName"></span> batch code </b>&emsp;<font size="-2">(last updated 11th February 2022)</font>
-  <div id="table"></div>
+    <b>Check out your <span class="companyName"></span> batch code </b>&emsp;<font size="-2">(last updated 11th February
+      2022)</font>
+  <div id="batchCodeTableWrapper"></div>
   </p>
 </body>
 
diff --git a/forkMeOnGitHub.css b/forkMeOnGitHub.css
new file mode 100644
index 00000000000..37c46365b06
--- /dev/null
+++ b/forkMeOnGitHub.css
@@ -0,0 +1,63 @@
+/* adapted from https: //codepo8.github.io/css-fork-on-github-ribbon/ */
+
+#forkongithub a {
+    background: #000;
+    color: #fff;
+    text-decoration: none;
+    font-family: arial, sans-serif;
+    text-align: center;
+    font-weight: bold;
+    padding: 5px 40px;
+    font-size: 1rem;
+    line-height: 2rem;
+    position: relative;
+    transition: 0.5s;
+}
+
+#forkongithub a:hover {
+    background: #c11;
+    color: #fff;
+}
+
+#forkongithub a::before,
+#forkongithub a::after {
+    content: "";
+    width: 100%;
+    display: block;
+    position: absolute;
+    top: 1px;
+    left: 0;
+    height: 1px;
+    background: #fff;
+}
+
+#forkongithub a::after {
+    bottom: 1px;
+    top: auto;
+}
+
+@media screen and (min-width:800px) {
+    #forkongithub {
+        position: absolute;
+        display: block;
+        top: 0;
+        right: 0;
+        width: 200px;
+        overflow: hidden;
+        height: 200px;
+        z-index: 9999;
+    }
+
+    #forkongithub a {
+        width: 200px;
+        position: absolute;
+        top: 60px;
+        right: -60px;
+        transform: rotate(45deg);
+        -webkit-transform: rotate(45deg);
+        -ms-transform: rotate(45deg);
+        -moz-transform: rotate(45deg);
+        -o-transform: rotate(45deg);
+        box-shadow: 4px 4px 10px rgba(0, 0, 0, 0.8);
+    }
+}
\ No newline at end of file
diff --git a/index.html b/index.html
index 5759d4edcef..0651eaca816 100644
--- a/index.html
+++ b/index.html
@@ -5,73 +5,11 @@
 <head>
   <meta name="viewport" content="width=device-width, initial-scale=1.0" />
   <title>How Bad is My Batch</title>
+  <link rel="stylesheet" type="text/css" href="forkMeOnGitHub.css">
 </head>
 
 <body>
-  <!-- adapted from https://codepo8.github.io/css-fork-on-github-ribbon/ -->
-  <style>
-    #forkongithub a {
-      background: #000;
-      color: #fff;
-      text-decoration: none;
-      font-family: arial, sans-serif;
-      text-align: center;
-      font-weight: bold;
-      padding: 5px 40px;
-      font-size: 1rem;
-      line-height: 2rem;
-      position: relative;
-      transition: 0.5s;
-    }
-
-    #forkongithub a:hover {
-      background: #c11;
-      color: #fff;
-    }
-
-    #forkongithub a::before,
-    #forkongithub a::after {
-      content: "";
-      width: 100%;
-      display: block;
-      position: absolute;
-      top: 1px;
-      left: 0;
-      height: 1px;
-      background: #fff;
-    }
-
-    #forkongithub a::after {
-      bottom: 1px;
-      top: auto;
-    }
-
-    @media screen and (min-width:800px) {
-      #forkongithub {
-        position: absolute;
-        display: block;
-        top: 0;
-        right: 0;
-        width: 200px;
-        overflow: hidden;
-        height: 200px;
-        z-index: 9999;
-      }
-
-      #forkongithub a {
-        width: 200px;
-        position: absolute;
-        top: 60px;
-        right: -60px;
-        transform: rotate(45deg);
-        -webkit-transform: rotate(45deg);
-        -ms-transform: rotate(45deg);
-        -moz-transform: rotate(45deg);
-        -o-transform: rotate(45deg);
-        box-shadow: 4px 4px 10px rgba(0, 0, 0, 0.8);
-      }
-    }
-  </style><span id="forkongithub"><a href="https://github.com/KnollFrank/HowBadIsMyBatch">Fork me on GitHub</a></span>
+  <span id="forkongithub"><a href="https://github.com/KnollFrank/HowBadIsMyBatch">Fork me on GitHub</a></span>
   <h1>How Bad is My Batch</h1>
   <p>
   <ul>
