refactoring

This commit is contained in:
frankknoll
2023-04-14 11:51:40 +02:00
parent 963f60dc5a
commit 5927575ec8
3 changed files with 4 additions and 5 deletions

View File

@@ -1,5 +1,4 @@
// FK-TODO: rename to BatchCodeDetailsView class BatchCodeDetailsView {
class HistogramView {
#uiContainer; #uiContainer;
@@ -8,7 +7,7 @@ class HistogramView {
} }
// FK-TODO: unbind all events here and in HistogramChartView // FK-TODO: unbind all events here and in HistogramChartView
displayHistogramView(batchcode) { displayBatchCodeDetails(batchcode) {
this this
.#loadHistoDescrs(batchcode) .#loadHistoDescrs(batchcode)
.then(histoDescrs => this.#displayHistogramViewForHistoDescrs(histoDescrs)); .then(histoDescrs => this.#displayHistogramViewForHistoDescrs(histoDescrs));

View File

@@ -6,7 +6,7 @@ class BatchCodeSelectInitializer {
'select2:select', 'select2:select',
function (event) { function (event) {
const batchcode = event.params.data.id; const batchcode = event.params.data.id;
new HistogramView(batchCodeDetailsElement).displayHistogramView(batchcode); new BatchCodeDetailsView(batchCodeDetailsElement).displayBatchCodeDetails(batchcode);
GoogleAnalytics.click_batchcode(batchcode); GoogleAnalytics.click_batchcode(batchcode);
}); });
batchCodeSelectElement.select2('open'); batchCodeSelectElement.select2('open');

View File

@@ -36,7 +36,7 @@
<script src="./HistogramChartView.js"></script> <script src="./HistogramChartView.js"></script>
<script src="./AdverseReactionReportsChartView.js"></script> <script src="./AdverseReactionReportsChartView.js"></script>
<script src="./BatchcodeCombinationSelection.js"></script> <script src="./BatchcodeCombinationSelection.js"></script>
<script src="./HistogramView.js"></script> <script src="./BatchCodeDetailsView.js"></script>
<script> <script>
$(document).ready(function () { $(document).ready(function () {
BatchCodeSelectInitializer.initialize( BatchCodeSelectInitializer.initialize(