diff --git a/docs/SymptomsCausedByDrugs/js/PrrByVaccineProvider.js b/docs/SymptomsCausedByDrugs/js/PrrByVaccineProvider.js index 5f7cff61a54..c41b5eaa99a 100644 --- a/docs/SymptomsCausedByDrugs/js/PrrByVaccineProvider.js +++ b/docs/SymptomsCausedByDrugs/js/PrrByVaccineProvider.js @@ -1,10 +1,10 @@ class PrrByVaccineProvider { static getPrrByVaccine(symptom) { - return fetch(`./data/ProportionalReportingRatios/symptoms/${symptom}.json`).then(response => response.json()); + return fetch(`./data/ProportionalReportingRatios/symptoms/${symptom}`).then(response => response.json()); } static getPrrBySymptom(vaccine) { - return fetch(`./data/ProportionalReportingRatios/vaccines/${vaccine}.json`).then(response => response.json()); + return fetch(`./data/ProportionalReportingRatios/vaccines/${vaccine}`).then(response => response.json()); } } \ No newline at end of file diff --git a/src/SymptomsCausedByVaccines/HtmlUpdater.py b/src/SymptomsCausedByVaccines/HtmlUpdater.py index 1747a207aaf..34d604b962f 100644 --- a/src/SymptomsCausedByVaccines/HtmlUpdater.py +++ b/src/SymptomsCausedByVaccines/HtmlUpdater.py @@ -5,14 +5,19 @@ from SymptomsCausedByVaccines.HtmlUtils import getSymptomOptions, getVaccineOpti from SymptomsCausedByVaccines.OptionsSetter import OptionsSetter -def updateHtmlFile(symptoms, vaccines, htmlFile, defaultSelectVaccineOptionText = 'Select Vaccine'): +def updateHtmlFile(symptomsDescr, vaccinesDescr, htmlFile, defaultSelectVaccineOptionText = 'Select Vaccine'): _saveOptions( - options = getSymptomOptions(symptoms), + options = getSymptomOptions( + symptoms = symptomsDescr['symptoms'], + filenameBySymptom = symptomsDescr['filenameBySymptom']), htmlFile = htmlFile, selectElementId = 'symptomSelect') _saveOptions( - options = getVaccineOptions(vaccines, defaultSelectVaccineOptionText), + options = getVaccineOptions( + vaccines = vaccinesDescr['vaccines'], + filenameByDrug = vaccinesDescr['filenameByDrug'], + defaultOptionText = defaultSelectVaccineOptionText), htmlFile = htmlFile, selectElementId = 'vaccineSelect') diff --git a/src/SymptomsCausedByVaccines/HtmlUtils.py b/src/SymptomsCausedByVaccines/HtmlUtils.py index cfff42d3c85..d3d79073769 100644 --- a/src/SymptomsCausedByVaccines/HtmlUtils.py +++ b/src/SymptomsCausedByVaccines/HtmlUtils.py @@ -1,20 +1,28 @@ import html -def getVaccineOptions(vaccines, defaultOptionText): - return _getOptionsWithDefaultOption(defaultOptionText = defaultOptionText, values = vaccines) +def getVaccineOptions(vaccines, filenameByDrug, defaultOptionText): + return _getOptionsWithDefaultOption( + defaultOptionText = defaultOptionText, + values = vaccines, + filenameByValue = filenameByDrug) -def getSymptomOptions(symptoms): - return _getOptionsWithDefaultOption(defaultOptionText = 'Select Symptom', values = symptoms) +def getSymptomOptions(symptoms, filenameBySymptom): + return _getOptionsWithDefaultOption( + defaultOptionText = 'Select Symptom', + values = symptoms, + filenameByValue = filenameBySymptom) -def _getOptionsWithDefaultOption(defaultOptionText, values): - return [''.format(defaultOptionText = defaultOptionText)] + _getOptions(values) +def _getOptionsWithDefaultOption(defaultOptionText, values, filenameByValue): + return [''.format(defaultOptionText = defaultOptionText)] + _getOptions(values, filenameByValue) -def _getOptions(values): - return [_getOption(value) for value in values] +def _getOptions(values, filenameByValue): + return [_getOption(filename = filenameByValue[value], displayValue = value) for value in values] -def _getOption(value): - return ''.format(value = html.escape(value)) +def _getOption(filename, displayValue): + return ''.format( + value = filename, + displayValue = html.escape(displayValue)) diff --git a/src/SymptomsCausedByVaccines/ProportionalReportingRatiosPersister.py b/src/SymptomsCausedByVaccines/ProportionalReportingRatiosPersister.py index 4dcc1b5d98e..171c2be699d 100644 --- a/src/SymptomsCausedByVaccines/ProportionalReportingRatiosPersister.py +++ b/src/SymptomsCausedByVaccines/ProportionalReportingRatiosPersister.py @@ -10,4 +10,4 @@ def saveProportionalReportingRatios(prrBySymptomByDrug, directory): filename = f'{i}.json' filenameByDrug[drug] = filename IOUtils.saveDictAsJson(prrBySymptom, f'{directory}/{filename}') - IOUtils.saveDictAsJson(filenameByDrug, f'{directory}/filenameByDrug.json') + return filenameByDrug diff --git a/src/SymptomsCausedByVaccines/ProportionalReportingRatiosPersisterTest.py b/src/SymptomsCausedByVaccines/ProportionalReportingRatiosPersisterTest.py index 5f412d384f3..7aa313d280b 100644 --- a/src/SymptomsCausedByVaccines/ProportionalReportingRatiosPersisterTest.py +++ b/src/SymptomsCausedByVaccines/ProportionalReportingRatiosPersisterTest.py @@ -18,16 +18,14 @@ class ProportionalReportingRatiosPersisterTest(unittest.TestCase): directory = 'src/tmp/vaccines' # When - saveProportionalReportingRatios(prrBySymptomByDrug, directory) + filenameByDrug = saveProportionalReportingRatios(prrBySymptomByDrug, directory) # Then drugFilename = '1.json' self.assertDictEqual( ProportionalReportingRatiosPersisterTest.readJsonFile(f'{directory}/{drugFilename}'), prrBySymptom) - self.assertDictEqual( - ProportionalReportingRatiosPersisterTest.readJsonFile(f'{directory}/filenameByDrug.json'), - { drug: drugFilename }) + self.assertDictEqual(filenameByDrug, { drug: drugFilename }) @staticmethod def readJsonFile(file):