From 41d7141f3611cc6c9345dbe7cd56f356c7446599 Mon Sep 17 00:00:00 2001 From: frankknoll Date: Tue, 3 Oct 2023 20:39:32 +0200 Subject: [PATCH] refactoring --- .../{GoogleAnalyticsReader.py => FilesProvider.py} | 2 +- ...leAnalyticsReaderTest.py => FilesProviderTest.py} | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) rename src/GoogleAnalytics/{GoogleAnalyticsReader.py => FilesProvider.py} (92%) rename src/GoogleAnalytics/{GoogleAnalyticsReaderTest.py => FilesProviderTest.py} (58%) diff --git a/src/GoogleAnalytics/GoogleAnalyticsReader.py b/src/GoogleAnalytics/FilesProvider.py similarity index 92% rename from src/GoogleAnalytics/GoogleAnalyticsReader.py rename to src/GoogleAnalytics/FilesProvider.py index 3643ffdb2c3..8ea41e72200 100644 --- a/src/GoogleAnalytics/GoogleAnalyticsReader.py +++ b/src/GoogleAnalytics/FilesProvider.py @@ -2,7 +2,7 @@ import glob from GoogleAnalytics.ResolutionProvider import ResolutionProvider -class GoogleAnalyticsReader: +class FilesProvider: def __init__(self, dataDir): self.dataDir = dataDir diff --git a/src/GoogleAnalytics/GoogleAnalyticsReaderTest.py b/src/GoogleAnalytics/FilesProviderTest.py similarity index 58% rename from src/GoogleAnalytics/GoogleAnalyticsReaderTest.py rename to src/GoogleAnalytics/FilesProviderTest.py index e5e1c5f37ab..ecb8b46eadb 100644 --- a/src/GoogleAnalytics/GoogleAnalyticsReaderTest.py +++ b/src/GoogleAnalytics/FilesProviderTest.py @@ -1,25 +1,25 @@ import unittest from GoogleAnalytics.ResolutionProvider import Resolution -from GoogleAnalytics.GoogleAnalyticsReader import GoogleAnalyticsReader +from GoogleAnalytics.FilesProvider import FilesProvider -class GoogleAnalyticsReaderTest(unittest.TestCase): +class FilesProviderTest(unittest.TestCase): def test_getFilesHavingCityResolution(self): # Given - googleAnalyticsReader = GoogleAnalyticsReader(dataDir = 'src/testdata/GoogleAnalytics') + filesProvider = FilesProvider(dataDir = 'src/testdata/GoogleAnalytics') # When - files = googleAnalyticsReader.getFilesHavingResolution(Resolution.CITY) + files = filesProvider.getFilesHavingResolution(Resolution.CITY) # Then self.assertEqual(files, ['src/testdata/GoogleAnalytics/CountryByBatchcode 20230730-20230929.csv']) def test_getFilesHavingCountryResolution(self): # Given - googleAnalyticsReader = GoogleAnalyticsReader(dataDir = 'src/testdata/GoogleAnalytics') + filesProvider = FilesProvider(dataDir = 'src/testdata/GoogleAnalytics') # When - files = googleAnalyticsReader.getFilesHavingResolution(Resolution.COUNTRY) + files = filesProvider.getFilesHavingResolution(Resolution.COUNTRY) # Then self.assertEqual(