From 2cc3b29ed3e53dcac241963dfdbb55237db6a88e Mon Sep 17 00:00:00 2001 From: Frank Knoll Date: Fri, 12 Jul 2024 07:44:29 +0200 Subject: [PATCH] refining ProportionalReportingRatiosPersisterTest --- .../ProportionalReportingRatiosPersister.py | 5 ++--- .../ProportionalReportingRatiosPersisterTest.py | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/SymptomsCausedByVaccines/ProportionalReportingRatiosPersister.py b/src/SymptomsCausedByVaccines/ProportionalReportingRatiosPersister.py index 171c2be699d..ef40a27a47c 100644 --- a/src/SymptomsCausedByVaccines/ProportionalReportingRatiosPersister.py +++ b/src/SymptomsCausedByVaccines/ProportionalReportingRatiosPersister.py @@ -7,7 +7,6 @@ def saveProportionalReportingRatios(prrBySymptomByDrug, directory): i = 0 for drug, prrBySymptom in prrBySymptomByDrug.items(): i += 1 - filename = f'{i}.json' - filenameByDrug[drug] = filename - IOUtils.saveDictAsJson(prrBySymptom, f'{directory}/{filename}') + filenameByDrug[drug] = f'{i}' + IOUtils.saveDictAsJson(prrBySymptom, f'{directory}/{i}.json') return filenameByDrug diff --git a/src/SymptomsCausedByVaccines/ProportionalReportingRatiosPersisterTest.py b/src/SymptomsCausedByVaccines/ProportionalReportingRatiosPersisterTest.py index 7aa313d280b..f23605d4c1e 100644 --- a/src/SymptomsCausedByVaccines/ProportionalReportingRatiosPersisterTest.py +++ b/src/SymptomsCausedByVaccines/ProportionalReportingRatiosPersisterTest.py @@ -21,9 +21,9 @@ class ProportionalReportingRatiosPersisterTest(unittest.TestCase): filenameByDrug = saveProportionalReportingRatios(prrBySymptomByDrug, directory) # Then - drugFilename = '1.json' + drugFilename = '1' self.assertDictEqual( - ProportionalReportingRatiosPersisterTest.readJsonFile(f'{directory}/{drugFilename}'), + ProportionalReportingRatiosPersisterTest.readJsonFile(f'{directory}/{drugFilename}.json'), prrBySymptom) self.assertDictEqual(filenameByDrug, { drug: drugFilename })