refactoring

This commit is contained in:
frankknoll
2023-04-18 17:21:41 +02:00
parent 71c7f8d261
commit 0fc151cccc
3 changed files with 23 additions and 9 deletions

View File

@@ -40,15 +40,14 @@ class HistogramTable {
]
},
{
render: (data, type, row, meta) => {
// FK-TODO: refactor
const numberWithBar = UIUtils.instantiateTemplate('template-number-with-bar');
const bar = numberWithBar.querySelector('.bar');
bar.style.width = (data / this.#sumFrequencies * 100).toString() + "%";
const number = numberWithBar.querySelector('.number');
number.textContent = data;
return numberWithBar.outerHTML;
},
render: frequency =>
NumberWithBarElementFactory
.createNumberWithBarElement(
{
number: frequency,
barLenInPercent: frequency / this.#sumFrequencies * 100
})
.outerHTML,
targets: [this.#getColumnIndex('Frequency')]
}
]

View File

@@ -0,0 +1,14 @@
class NumberWithBarElementFactory {
static createNumberWithBarElement({ number, barLenInPercent }) {
const numberWithBarElement = UIUtils.instantiateTemplate('template-number-with-bar');
const barElement = numberWithBarElement.querySelector('.bar');
barElement.style.width = barLenInPercent.toString() + "%";
const numberElement = numberWithBarElement.querySelector('.number');
numberElement.textContent = number;
return numberWithBarElement;
}
}

View File

@@ -28,6 +28,7 @@
<link href="forkMeOnGitHub.css" rel="stylesheet" type="text/css" />
<script src="./Utils.js"></script>
<script src="./UIUtils.js"></script>
<script src="./NumberWithBarElementFactory.js"></script>
<script src="./GoogleAnalytics.js"></script>
<script src="./BatchCodeSelectInitializer.js"></script>
<script src="./HistoDescrsProvider.js"></script>