From 0cba738d267c7a4ae1ab0c1a8a2cae2e2c468a6d Mon Sep 17 00:00:00 2001
From: frankknoll <Knoll_Frank@web.de>
Date: Sun, 11 Jun 2023 02:07:48 +0200
Subject: [PATCH] refactoring

---
 src/GoogleAnalyticsReader.py | 11 ++++++++---
 src/HowBadIsMyBatch.ipynb    | 14 ++++++++++++++
 2 files changed, 22 insertions(+), 3 deletions(-)

diff --git a/src/GoogleAnalyticsReader.py b/src/GoogleAnalyticsReader.py
index 7a04b99ea59..dbb3ff2f801 100644
--- a/src/GoogleAnalyticsReader.py
+++ b/src/GoogleAnalyticsReader.py
@@ -26,7 +26,12 @@ class GoogleAnalyticsReader:
         return datetime.strptime(str, '%Y%m%d').date()
     
     def _getMinMaxDateRange(self, dateRanges):
-        minDateRange = min([dateRange[0] for dateRange in dateRanges])
-        maxDateRange = max([dateRange[1] for dateRange in dateRanges])
-        return minDateRange, maxDateRange
+        minStartDate = min([self._getStartDate(dateRange) for dateRange in dateRanges])
+        maxEndDate = max([self._getEndDate(dateRange) for dateRange in dateRanges])
+        return minStartDate, maxEndDate
+    
+    def _getStartDate(self, dateRange):
+        return dateRange[0]
 
+    def _getEndDate(self, dateRange):
+        return dateRange[1]
diff --git a/src/HowBadIsMyBatch.ipynb b/src/HowBadIsMyBatch.ipynb
index 50021171d06..8f1510121c4 100644
--- a/src/HowBadIsMyBatch.ipynb
+++ b/src/HowBadIsMyBatch.ipynb
@@ -207,6 +207,20 @@
     "barChartDescriptionTable['BAR_CHART_DESCRIPTION'].to_json('../docs/data/barChartDescriptionTable.json')"
    ]
   },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "id": "af8b598c",
+   "metadata": {},
+   "outputs": [],
+   "source": [
+    "from GoogleAnalyticsReader import GoogleAnalyticsReader\n",
+    "\n",
+    "googleAnalyticsReader = GoogleAnalyticsReader(dataDir = 'data/GoogleAnalytics')\n",
+    "dateRange = googleAnalyticsReader.getDateRange()\n",
+    "dateRange"
+   ]
+  },
   {
    "attachments": {},
    "cell_type": "markdown",